feat(CDPSDK-2436): add CreateSubscription for Webhook Events#634
Open
feat(CDPSDK-2436): add CreateSubscription for Webhook Events#634
Conversation
🟡 Heimdall Review Status
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sddioulde
reviewed
Apr 3, 2026
Contributor
sddioulde
left a comment
sddioulde
left a comment
There was a problem hiding this comment.
looks good. i think we should add a test from the webhooks client perspective so that we are sure it is correctly wired to the action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the CreateSubscription method to the Webhooks client.
Tests
Unit tests have been added for this new method. In addition, this has been tested in dev.
Checklist
A couple of things to include in your PR for completeness: